Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gir errors a bit #766

Merged
merged 2 commits into from May 16, 2019
Merged

Improve gir errors a bit #766

merged 2 commits into from May 16, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #681.

cc @bochecha @EPashkin @sdroege

Errors look like this now (not much changes but that's a start!):

GirXml: ../gir-files/GLib-2.0.gir at line 31840:10: <type> element is missing a name attribute

@EPashkin
Copy link
Member

Hm, stable and nightly has different formatting rules
@GuillaumeGomez Thanks for fixes.
Can you do cargo +stable fmt ?

@GuillaumeGomez
Copy link
Member Author

Arf, cargo fmt is on the run!

@EPashkin
Copy link
Member

Good that it was just unformated.
@GuillaumeGomez Thanks

@EPashkin EPashkin merged commit 75915f1 into gtk-rs:master May 16, 2019
@GuillaumeGomez GuillaumeGomez deleted the errors branch May 16, 2019 09:01
@GuillaumeGomez
Copy link
Member Author

I can predict that a lot of my future pull requests will have this issue. :-°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuillaumeGomez @EPashkin